-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biocatalysis Demo Vocabulary for pipeline testing #2
Conversation
Hi @dalito, `Run voc4cat --version voc4cat 0.7.8 |
I somewhat expected some failures. I don't have time to look now. The main difference between here and the voc4cat repo is that voc4cat is constrained to one vocab per repo whereas here you can have multiple vocab in the same repo. This has not been tested much. |
The reason for the failure is that the ORCID and ROR in the config
It would be nice if the custom validators for ORCID & ROR would give more meaningful error messages. However, I don't plan to add features to current pydantic 1 code. For pydantic 2 the custom validation has to be rewritten (nfdi4cat/voc4cat-tool#142). The easiest fix is to replace ORCID and ROR with an empty string (or with valid values). I did this in #3. |
@markdoerr - Rerunning the job gave another error. This one is for you. :) |
Thanks, @dalito, |
Biocatalysis Vocabulary v1.1