Create pre-commit hooks #3141
Open
Create pre-commit hooks #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be in the pipeline template, no? |
|
They could be in the pipeline template, but I just made a seperate hook that just works for the pipeline and added that to the template. Might want to look at the stages options. I'm thinking |
edmundmiller
added a commit
to nf-core/modules
that referenced
this pull request
Nov 20, 2024
edmundmiller
added a commit
to nf-core/modules
that referenced
this pull request
Nov 20, 2024
Co-authored-by: mashehu <[email protected]>
edmundmiller
force-pushed
the
pre-commit
branch
from
df23fa0 to
cffb787
Compare
edmundmiller
added a commit
to nf-core/modules
that referenced
this pull request
Nov 21, 2024
* ci: Fix linting getting skipped * ci: Add list-files json * ci: Why do we need a Docker container again? * ci: Can't use a script if it doesn't exist yet Co-authored-by: adamrtalbot <[email protected]> * ci: Skip outputs if they're empty * style: Run lsp on fastqc * ci: Use files to skip extra steps * ci(lint): Get the module name nf-core/tools#3141 * ci: Add what shell to run on * ci: Clean up the names in the filter step * ci: Add hack to only lint the real changes * ci: Add more to debug step * ci(lint): Get fancy with map * ci: One more time * ci: Maybe? * ci: results => result * ci: Death by a thousand s's * ci: Use Set * ci: Use one at a time * ci(gpu): Update step name * ci: Remove clean workspace after run * ci: Why does that break things? * Revert "style: Run lsp on fastqc" This reverts commit da64fce. --------- Co-authored-by: adamrtalbot <[email protected]>
edmundmiller
force-pushed
the
pre-commit
branch
from
cffb787 to
e41f8c2
Compare
edmundmiller
force-pushed
the
pre-commit
branch
from
e41f8c2 to
e4a2f4c
Compare
|
Removed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
mashehu
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-commit hooks config for the repo.
Blocked by #3140 currently. Docs if anyone has any ideas https://pre-commit.com/#new-hooks