Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version for 3.0 release #403

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Bump version for 3.0 release #403

merged 2 commits into from
Dec 9, 2024

Conversation

grst
Copy link
Member

@grst grst commented Dec 9, 2024 •
edited
Loading

No description provided.

@grst grst changed the base branch from master to dev December 9, 2024 07:37
@nf-core nf-core deleted a comment from github-actions bot Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit eaca45a

+| ✅ 214 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 3.0.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-09 07:46:31

@grst grst mentioned this pull request Dec 9, 2024
Merged
12 tasks
@grst grst requested a review from fmalmeida December 9, 2024 07:53
mashehu
mashehu approved these changes Dec 9, 2024
View reviewed changes
nextflow.config
// Load nf-core/scrnaseq custom profiles from different institutions.
// TODO nf-core: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
// includeConfig !System.getenv('NXF_OFFLINE') && params.custom_config_base ? "${params.custom_config_base}/pipeline/scrnaseq.config" : "/dev/null"
includeConfig !System.getenv('NXF_OFFLINE') && params.custom_config_base ? "${params.custom_config_base}/pipeline/scrnaseq.config" : "/dev/null"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky version bump addition 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky update of the nf-core tools linter :P
That check didn't fail last week ;)

@grst grst merged commit 1a84433 into dev Dec 9, 2024
16 checks passed
@grst grst deleted the bump-version branch December 9, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@fmalmeida fmalmeida Awaiting requested review from fmalmeida

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes due to trying to unzip file that is not zipped
2 participants
@grst @mashehu