Skip to content

Commit

Permalink
change skip_emptydrops to skip_cellbender
Browse files Browse the repository at this point in the history
  • Loading branch information
zxBIB Almeida,Felipe (GCBDS) EXTERNAL committed Jan 20, 2025
1 parent 0316a79 commit d5679c9
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ process {
]
}

if (!params.skip_emptydrops) {
if (!params.skip_cellbender) {
withName: 'CELLBENDER_REMOVEBACKGROUND' {
publishDir = [
path: { "${params.outdir}/${params.aligner}/${meta.id}/cellbender_removebackground" },
Expand Down
2 changes: 1 addition & 1 deletion conf/test.config
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ params {

// Input data
input = 'https://github.com/nf-core/test-datasets/raw/scrnaseq/samplesheet-2-0.csv'
skip_emptydrops = true // module does not work on small dataset
skip_cellbender = true // module does not work on small dataset

// Genome references
fasta = 'https://github.com/nf-core/test-datasets/raw/scrnaseq/reference/GRCm38.p6.genome.chr19.fa'
Expand Down
2 changes: 1 addition & 1 deletion conf/test_cellranger_multi.config
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ params {
cellranger_multi_barcodes = "${projectDir}/assets/cellranger_barcodes_samplesheet.csv"
gex_frna_probe_set = "${projectDir}/assets/frna_probeset_subset.csv"
fb_reference = "${projectDir}/assets/fb_reference.csv"
skip_emptydrops = true // not enough data in small test
skip_cellbender = true // not enough data in small test

// Genome references
fasta = 'https://ftp.ensembl.org/pub/release-110/fasta/homo_sapiens/dna/Homo_sapiens.GRCh38.dna.chromosome.14.fa.gz'
Expand Down
2 changes: 1 addition & 1 deletion docs/output.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ for the corresponding documentation.

The pipeline also possess a subworkflow imported from scdownstream to perform filter empty drops using [cellbender](https://github.com/broadinstitute/CellBender) remove background function. The process is simple, it takes a raw/unfiltered matrix file, and performs the filltering on it, generating another matrix file.

> Users can turn it of with `--skip_emptydrops`.
> Users can turn it of with `--skip_cellbender`.
**Output directory: `results/${params.aligner}/${meta.id}/cellbender_removebackground`**

Expand Down
2 changes: 1 addition & 1 deletion nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ params {
cellrangerarc_reference = null

// Emptydrops parameters
skip_emptydrops = false
skip_cellbender = false

// CellrangerMulti parameters
cellranger_vdj_index = null
Expand Down
2 changes: 1 addition & 1 deletion nextflow_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"type": "boolean",
"description": "Skip FastQC"
},
"skip_emptydrops": {
"skip_cellbender": {
"type": "boolean",
"description": "Skip cellbender empty drops filter subworkflow"
}
Expand Down
2 changes: 1 addition & 1 deletion tests/main_pipeline_cellrangermulti.nf.test
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ nextflow_pipeline {
gtf = 'https://ftp.ensembl.org/pub/release-110/gtf/homo_sapiens/Homo_sapiens.GRCh38.110.gtf.gz'
aligner = 'cellrangermulti'
protocol = 'auto'
skip_emptydrops = true
skip_cellbender = true
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ params {
protocol = '10XV2'

// small dataset does not have sufficient data for emptydrops module
skip_emptydrops = true
skip_cellbender = true

validationSchemaIgnoreParams = 'genomes'
}
Expand Down
2 changes: 1 addition & 1 deletion workflows/scrnaseq.nf
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ workflow SCRNASEQ {
//
// SUBWORKFLOW: Run cellbender remove background subworkflow
//
if ( !params.skip_emptydrops && !(params.aligner in ['cellrangerarc']) ) {
if ( !params.skip_cellbender && !(params.aligner in ['cellrangerarc']) ) {
// module should only run on the raw matrices thus, filter-out the filtered result of the aligners that can produce it
H5AD_REMOVEBACKGROUND_BARCODES_CELLBENDER_ANNDATA (
ch_h5ads.filter { meta, mtx_files -> meta.input_type == 'raw' }
Expand Down

0 comments on commit d5679c9

Please sign in to comment.