Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.13.1 #473

Merged
merged 24 commits into from
Mar 15, 2024
Merged

Important! Template update for nf-core/tools v2.13.1 #473

merged 24 commits into from
Mar 15, 2024

Conversation

nf-core-bot
Copy link
Member

Version 2.13.1 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.13.1 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.13.1 release page.

@rannick rannick self-assigned this Mar 4, 2024
@rannick rannick changed the base branch from dev to merging_2.13.1 March 4, 2024 12:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 6e24086

+| ✅ 167 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-15 14:30:48

@rannick rannick requested a review from jemten March 4, 2024 19:01
jemten
jemten reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments :)

.github/CONTRIBUTING.md Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
assets/schema_input.json Show resolved Hide resolved
nextflow_schema.json Show resolved Hide resolved
workflows/rnafusion.nf Outdated Show resolved Hide resolved
jemten
jemten approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rannick rannick merged commit 05e647d into merging_2.13.1 Mar 15, 2024
5 of 6 checks passed
@rannick rannick deleted the nf-core-template-merge-2.13.1 branch March 15, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rannick rannick rannick left review comments

@jemten jemten jemten approved these changes

Assignees

@rannick rannick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-core-bot @jemten @rannick