Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from megafusion to vcf_collect #414

Merged
merged 55 commits into from
Nov 20, 2023
Merged

from megafusion to vcf_collect #414

merged 55 commits into from
Nov 20, 2023

Conversation

rannick
Copy link
Collaborator

@rannick rannick commented Sep 29, 2023 •
edited
Loading

Closes #365 and #356

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@rannick rannick self-assigned this Sep 29, 2023
@rannick rannick added the WIP Work in progress label Oct 2, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@rannick rannick added the waiting label Nov 1, 2023
fevac
fevac requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🌟

bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
fevac
fevac approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🚀

CHANGELOG.md Show resolved Hide resolved
fevac
fevac reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the issues I found here for simplicity

bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Outdated Show resolved Hide resolved
bin/vcf_collect.py Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
bin/vcf_collect.py Show resolved Hide resolved
@rannick rannick merged commit 152afdd into dev Nov 20, 2023
8 checks passed
@rannick rannick deleted the megafusion_to_vcf_collect branch November 20, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fevac fevac fevac approved these changes

@peterpru peterpru peterpru approved these changes

Assignees

@rannick rannick

Labels
waiting WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add to VCF report
3 participants
@rannick @fevac @peterpru