Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typos #98

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Fixed typos #98

merged 4 commits into from
Sep 12, 2024

Conversation

bounlu
Copy link

@bounlu bounlu commented Sep 11, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 70e9480

+| ✅ 178 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗  12 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • schema_params - Schema param panel not found from nextflow config
  • schema_params - Schema param genome_version not found from nextflow config
  • schema_params - Schema param genome_type not found from nextflow config
  • schema_params - Schema param ref_data_hmf_data_path not found from nextflow config
  • schema_params - Schema param ref_data_panel_data_path not found from nextflow config
  • schema_params - Schema param ref_data_virusbreakenddb_path not found from nextflow config
  • schema_params - Schema param ref_data_hla_slice_bed not found from nextflow config

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-11 23:08:48

@scwatts scwatts self-requested a review September 11, 2024 23:03
@scwatts scwatts added the enhancement New feature or request label Sep 11, 2024
@scwatts scwatts added this to the Release 1.1.0 milestone Sep 11, 2024
scwatts
scwatts approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@scwatts scwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@bounlu bounlu merged commit 1144edb into dev Sep 12, 2024
4 checks passed
@bounlu bounlu deleted the bounlu-fix-typos branch September 12, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scwatts scwatts scwatts approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bounlu @scwatts