Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify custom/filterdifferentialtable to allow >=/<= #7258

Merged
merged 15 commits into from
Jan 10, 2025

Conversation

suzannejin
Copy link
Contributor

@suzannejin suzannejin commented Dec 20, 2024

This modification allows setting ">=" or "<=" comparisons through ext.args

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface is a little confusing here. But in any case, you're effectively making the cardinality a required input here, which means it should go in through a channel.

I suggest we change the inputs from:

    tuple val(meta), path(input_file)
    val(logFC_column)
    val(FC_threshold)
    val(padj_column)
    val(padj_threshold)

To:

    tuple val(meta), path(input_file)
    val(logFC_column)
    val(FC_threshold)
    val(FC_cardinality)
    val(padj_column)
    val(padj_threshold)
    val(padj_cardinality)

(removing the args thing altogether)

OR, maybe we also want to bundle these like:

    tuple val(meta), path(input_file)
    tuple val(logFC_column), val(FC_threshold), val(FC_cardinality)
    tuple val(padj_column), val(padj_threshold), val(padj_cardinality)

There should then be a check for a valid cardinality ('-', '<', '>', '<=', or '>=').

@suzannejin
Copy link
Contributor Author

@pinin4fjords Hello!! Thank you for the suggestions! Now the cardinal comparison operators are explicitly given as input :)

Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for addressing feedback

@suzannejin suzannejin added this pull request to the merge queue Jan 10, 2025
Merged via the queue into nf-core:master with commit 045f0fb Jan 10, 2025
27 checks passed
@suzannejin suzannejin deleted the filter_sign branch January 10, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants