-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify custom/filterdifferentialtable to allow >=/<= #7258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface is a little confusing here. But in any case, you're effectively making the cardinality a required input here, which means it should go in through a channel.
I suggest we change the inputs from:
tuple val(meta), path(input_file)
val(logFC_column)
val(FC_threshold)
val(padj_column)
val(padj_threshold)
To:
tuple val(meta), path(input_file)
val(logFC_column)
val(FC_threshold)
val(FC_cardinality)
val(padj_column)
val(padj_threshold)
val(padj_cardinality)
(removing the args thing altogether)
OR, maybe we also want to bundle these like:
tuple val(meta), path(input_file)
tuple val(logFC_column), val(FC_threshold), val(FC_cardinality)
tuple val(padj_column), val(padj_threshold), val(padj_cardinality)
There should then be a check for a valid cardinality ('-', '<', '>', '<=', or '>=').
…nto filter_sign
@pinin4fjords Hello!! Thank you for the suggestions! Now the cardinal comparison operators are explicitly given as input :) |
subworkflows/nf-core/abundance_differential_filter/tests/main.nf.test.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for addressing feedback
This modification allows setting ">=" or "<=" comparisons through ext.args
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda