-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port parabricks/deepvariant to nf-test #6995
Conversation
Currently assessing the created
|
Now the runners are picking up and some of the tests pass but some do not. Locally everything looks fine: nf-core modules test parabricks/deepvariant -u --profile docker
,--./,-.
___ __ __ __ ___ /,-._.--~\
|\ | |__ __ / ` / \ |__) |__ } {
| \| | \__, \__/ | \ |___ \`-._,-`-,
`._,._,'
nf-core/tools version 3.0.2 - https://nf-co.re
There is a new version of nf-core/tools available! (3.1.1)
INFO Generating nf-test snapshot
╭─────────────────────────────────────────────────────────────────────────────── nf-test output ───────────────────────────────────────────────────────────────────────────────╮
│ │
│ 🚀 nf-test 0.9.2 │
│ https://www.nf-test.com │
│ (c) 2021 - 2024 Lukas Forer and Sebastian Schoenherr │
│ │
│ Load .nf-test/plugins/nft-bam/0.5.0/nft-bam-0.5.0.jar │
│ Load .nf-test/plugins/nft-compress/0.1.0/nft-compress-0.1.0.jar │
│ Load .nf-test/plugins/nft-vcf/1.0.7/nft-vcf-1.0.7.jar │
│ Warning: every snapshot that fails during this test run is re-record. │
│ │
│ Test Process PARABRICKS_DEEPVARIANT │
│ │
│ Test [d4150cc7] 'human - bam' PASSED (19.026s) │
│ Test [7915f0a7] 'human - bam - intervals' PASSED (18.794s) │
│ Test [4a9986c1] 'human - bam - gvcf' PASSED (22.216s) │
│ Test [2608642d] 'human - bam - intervals - gvcf' PASSED (17.976s) │
│ Test [92648df2] 'human - bam - stub' PASSED (10.546s) │
│ Test [cd720ada] 'human - bam - intervals - gvcf - stub' PASSED (13.86s) │
│ │
│ │
│ SUCCESS: Executed 6 tests in 102.508s │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
INFO Generating nf-test snapshot again to check stability
╭─────────────────────────────────────────────────────────────────────────────── nf-test output ───────────────────────────────────────────────────────────────────────────────╮
│ │
│ 🚀 nf-test 0.9.2 │
│ https://www.nf-test.com │
│ (c) 2021 - 2024 Lukas Forer and Sebastian Schoenherr │
│ │
│ Load .nf-test/plugins/nft-bam/0.5.0/nft-bam-0.5.0.jar │
│ Load .nf-test/plugins/nft-compress/0.1.0/nft-compress-0.1.0.jar │
│ Load .nf-test/plugins/nft-vcf/1.0.7/nft-vcf-1.0.7.jar │
│ │
│ Test Process PARABRICKS_DEEPVARIANT │
│ │
│ Test [d4150cc7] 'human - bam' PASSED (20.539s) │
│ Test [7915f0a7] 'human - bam - intervals' PASSED (17.475s) │
│ Test [4a9986c1] 'human - bam - gvcf' PASSED (16.655s) │
│ Test [2608642d] 'human - bam - intervals - gvcf' PASSED (18.481s) │
│ Test [92648df2] 'human - bam - stub' PASSED (10.007s) │
│ Test [cd720ada] 'human - bam - intervals - gvcf - stub' PASSED (9.339s) │
│ │
│ │
│ SUCCESS: Executed 6 tests in 92.639s │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
INFO All tests passed! |
The runners seem to be giving a different md5sum for the |
I would wonder if the variants are in a different order, can you just print all the lines to the snapshot to see what is different. |
@SPPearce Changed it to assert the first 100 variants (which are more than are contained). Do you think thats ok? |
Sure, its just to try and debug the issue |
Now only the linting fails - so I am not sure why the md5sums are different on the runners and locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, tests are passing!
It would be nice to gzip the output for space reasons, but I'm not going to argue that.
Lets get this merged then for now :) I will put in a request with the parabricks people to enable |
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda