Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added merge count files per pool #4

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Added merge count files per pool #4

merged 6 commits into from
Apr 23, 2024

Conversation

BertGalle
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nvnieuwk
nvnieuwk reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some simple suggestions, but congrats on the first PR 🥳

modules/local/exomedepth/merge_count/main.nf Outdated Show resolved Hide resolved
workflows/exomecnv.nf Outdated Show resolved Hide resolved
BertGalle and others added 2 commits April 23, 2024 15:42
@BertGalle @nvnieuwk
Update modules/local/exomedepth/merge_count/main.nf
fca9d5d 
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
@BertGalle @nvnieuwk
Update workflows/exomecnv.nf
ffc19c7 
Co-authored-by: Nicolas Vannieuwkerke <[email protected]>
nvnieuwk
nvnieuwk approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Looks Good To Me)

@ToonRosseel
Copy link
Collaborator

Well done!

@ToonRosseel ToonRosseel merged commit 84f9766 into nf-cmgg:dev Apr 23, 2024
4 checks passed
@BertGalle BertGalle deleted the project1 branch April 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@ToonRosseel ToonRosseel Awaiting requested review from ToonRosseel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BertGalle @ToonRosseel @nvnieuwk