Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: Conditionally include upload rule #41

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Sep 14, 2023

Description of proposed changes

This change allows the workflow to run when s3_dst is not defined, since the upload rule requires it to be defined.

Related issue(s)

Checklist

  • Checks pass
  • Ingest workflow runs locally without s3_dst defined

This change allows the workflow to run when `s3_dst` is not defined,
since the upload rule requires it to be defined.
@victorlin victorlin self-assigned this Sep 14, 2023
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for catching this! I should have added this as part of #37.

@victorlin victorlin merged commit 0729bcd into master Sep 14, 2023
3 checks passed
@victorlin victorlin deleted the victorlin/fix-local-ingest branch September 14, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants