-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP resource listing for core data files #828
base: master
Are you sure you want to change the base?
Conversation
Allows review app to use an index with "data files" in it
4c9379b
to
6b369d5
Compare
I'm sorry I missed this when you first posted about it, @jameshadfield, but this is a super useful feature/resource! I wasn't sure which pathogens we actually had public data for (I forgot that I pushed cartography files up to S3) and I didn't realize the extent of the different files we produce for different pathogens (e.g., insertions, NDJSONs, and translations for mpox!). This seems like a major use case which is "I want to find out what pathogen datasets Nextstrain provides". Like you mentioned above, there some UI ideas to discuss about handling longer-lived datasets like RSV A below where the links scroll off to the right. I've always liked/preferred the "long page" approach to these types of data listings where I can scroll from the most recent results at the top to the first results at the bottom. What if you placed the dot plot at the top of the modal window as the visual representation of the data updates and then list the available datasets below that by data (sort of like a change log). This would look more like the SARS-CoV-2 remote inputs list but replicated by date. The idea there being that the other primary use case is probably (but we should check!) finding the latest or just-before-the-latest version of a specific file (like I want to use the latest metadata/alignments or the ones just before something broke in my workflow). I'd be curious to hear other ideas for use cases for this page, though. |
Looking at this again, I'm definitely a fan and don't think much needs to change. Mainly just fixing the overflow issue above etc... making the red x's a bit less strong, fixing the dates to not wrap. Basically just little UI cleanup rather than large new directions. My only more major suggestion would be to just start the info box with the latest results (without version ID) rather than trying to show a long table. And then you click on bubbles to replace these latest results with specific dated versions. Usually people will want latest files and starting with the big tables is a bit overwhelming. |
Thanks! Given John & Trevor's feedback on this prototype I'll find some time to bring the code & UI up to scratch and get this pushed out. |
A quick adaption of the current resource listing UI to display data files
Code is not production ready. I'd want to spend some time and tidy it up and implement proper composition/inheritance in the code for the different sources & resource types.
The UI likewise is rough around the edges, but it's working and it'd be good to get some feedback.
URL:/pathogens/files