dev: Check the Heroku build status during our GitHub Actions deploy job #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd been assuming builds on Heroku were always successful, which meant the GitHub Actions status could (and did) mask build issues on Heroku. Resolves <#726>.
nextstrain-bot
temporarily deployed
to
nextstrain-s-trs-check--jthqav
joverlee521
approved these changes
Oct 11, 2023
victorlin
approved these changes
Oct 11, 2023
|
Worked in the success condition: https://github.com/nextstrain/nextstrain.org/actions/runs/6486469947/job/17614896676#step:6:1 We'll see I guess in the future if it works in the failure condition. I don't think we need to intentionally fail a deploy to test it (but we could). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd been assuming builds on Heroku were always successful, which meant the GitHub Actions status could (and did) mask build issues on Heroku.
Resolves #726.
Checklist