Twitter Cards fix #145
Closed
Twitter Cards fix #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psthomas
force-pushed
the
twittercards-fix
branch
from
eea6416
to
0af4f7b
Compare
psthomas
force-pushed
the
twittercards-fix
branch
2 times, most recently
from
216f3cf
to
184ac37
Compare
The open graph image in the meta tags 404s because the siteLogo url in SiteConfig.js points to the location in the repo rather than the public location after the static site is built.
Adds a basic twitter summary card using the same title, image, and description as the open graph tags. Also improves the tag logic.
Adds a react component that can be imported into Auspice as an extension. This will sync the open graph and twitter tags with the current pathogen title, description and splash image.
psthomas
force-pushed
the
twittercards-fix
branch
from
184ac37
to
72eeab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This pull request fixes a dead link in the open graph tags and adds basic twitter tags to the head of the static site. These tags will only work for the static content at nextstrain.org, not for the auspice content yet.
It also adds a component that can be used as an extension in Auspice to keep the open graph and twitter tags in sync with the pathogen dataset/narrative. This commit has a demo of how this could be used in
head.jsthere.Related issue(s)
Related to #134
Testing
I uploaded the static site to Netlify to test on Twitter's card validator and it seems to work for all the static content. The integration with auspice should probably be tested in that repo.