Error boundaries for panels #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use error boundaries in more tightly scoped parts of auspice (e.g. surrounding the legend), presumably in response to specific bugs/crashes observed therein. This adds a panel-specific error boundary which surrounds each panel.
nextstrain-bot
temporarily deployed
to
auspice-james-panel-err-z5zy4s
|
Oh this is great, thanks! |
|
I can see this being very useful for #1888! I opened a PR to start using it in nextstrain.org too: nextstrain/nextstrain.org#1073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use error boundaries in more tightly scoped parts of auspice (e.g. surrounding the legend), presumably in response to specific bugs/crashes observed therein. This adds a panel-specific error boundary which surrounds each panel.
Here's how it looks with an error in every panel: