Move Jest config to TypeScript file #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-jest--kwycgs
victorlin
force-pushed
the
victorlin/jest-config
branch
from
ae5847e
to
1a1c62f
Compare
victorlin
force-pushed
the
victorlin/jest-config
branch
from
1a1c62f
to
f7a186a
Compare
jameshadfield
approved these changes
Nov 6, 2024
victorlin
force-pushed
the
victorlin/jest-config
branch
from
f7a186a
to
fef67b7
Compare
Reasons: 1. This is officially recommended <https://jestjs.io/docs/configuration> 2. Reduces clutter in package.json 3. Allows type checking and IDE hints for config options. ts-node is required to read the TypeScript configuration file.
victorlin
force-pushed
the
victorlin/jest-config
branch
from
fef67b7
to
f9b8ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Reasons:
Checklist
unit-testjobs passIf making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.