Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend usefulness of tip labels #1668

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Extend usefulness of tip labels #1668

merged 2 commits into from
Aug 28, 2024

Commits on Aug 26, 2024

  1. Tip label can be any node_attr

    Any normal `node_attr` in the tree can be used as a tip label, as well
    as the special-cases of strain-name and "none". Previously we only
    allowed valid colorings. Normal here means a node_attr value which is an
    object with a "value" key, thus excluding special-cases such as "div",
    "hidden", "vaccine" etc - see the JSON schema for more context
    <https://github.com/nextstrain/augur/blob/master/augur/data/schema-export-v2.json>
    jameshadfield committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3eb6ea8 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Tip label is used for on-hover+click info

    This generally better reflects the intention of changing the tip label
    key, which was previously only reflected in text drawn to the RHS of
    tree nodes at certain zoom levels.
    
    The motivating use case is the proliferation of datasets using an
    accession for `node.name` but who wish to see node names of another
    piece of metadata. This is possible by adding the desired name as a
    node_attr and (optionally) setting this as the default tip label.
    
    Note that the order of items in the node-clicked modal has been
    slightly altered and is now more consistent across internal branches,
    terminal branches & tips
    jameshadfield committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    399c501 View commit details
    Browse the repository at this point in the history