Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added x0uid Spotify Ad Block List #344

Closed
wants to merge 1 commit into from

Conversation

s0kil
Copy link

@s0kil s0kil commented Jul 24, 2020

Fixes #343

@crssi
Copy link

crssi commented Jul 25, 2020

This is nice... can you drop the https://github.com/nextdns/metadata/blob/master/privacy/blocklists/chef-koch-spotify.json in favor of this one.

See: #340 (comment)

@romaincointepas
Copy link
Member

I don't get why this blocklist has a separate whitelist (vs. a combined final hosts file).

x0uid/SpotifyAdBlock#24 is not reassuring.

@s0kil
Copy link
Author

s0kil commented Jul 26, 2020

@crssi Seems like that should be done in a separate PR.

@crssi
Copy link

crssi commented Jul 26, 2020

Actually I do not use Spotify at all, but I do think any project should not support plagiarisms and in this case CHEF-KOCH.
It would be a shame that supporting plagiarism would drop a shadow onto reliability. 😞

@romaincointepas
Copy link
Member

@x0uid would you be open to providing a unified blocklist that automatically removes the domains from the whitelist from the main list?

I may be missing something but I don't get the duo blocklist with false positives then separate whitelist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotify Ads Hosts List
3 participants