fix(test): increase timeout #6203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
approved these changes
Aug 13, 2024
elzody
force-pushed
the
fix/image-test
branch
3 times, most recently
from
221f4ae
to
c734317
Compare
|
Test summaryRun details
Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
juliusknorr
reviewed
Aug 14, 2024
| ? cy.wrap(subject).find('[data-text-el="editor-container"]') | ||
| : cy.get('[data-text-el="editor-container"]') | ||
| ? cy.wrap(subject).find('[data-text-el="editor-container"]', { timeout: 20000 }) | ||
| : cy.get('[data-text-el="editor-container"]', { timeout: 20000 }) |
There was a problem hiding this comment.
Looking at the replay it seems to be not the timeout but somehow viewer is not opening but the file is downloaded instead:
juliusknorr
force-pushed
the
fix/image-test
branch
2 times, most recently
from
f7c6714
to
0fa3fb5
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
juliusknorr
force-pushed
the
fix/image-test
branch
from
be950ab
to
9dc8634
Compare
|
New attempt use chrome instead of electron, now downgrading to 114 due to the running out of memory error. If that passes generally we may also want to try to bump cypress and keep chrome pinned for now Next could be the fix from cypress-io/cypress#27415 (comment) |
juliusknorr
force-pushed
the
fix/image-test
branch
from
9dc8634
to
6842d39
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/image-test
branch
from
6842d39
to
893ab3b
Compare
|
Let me close this as it seems a timeout is not the problem and my attempts also failed 😢 |
auto-merge was automatically disabled
September 13, 2024 08:14
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix
ImageView.spec.js. The issue seemed to be that the elements were loading, but too slowly and the Cypress commands timed out. Adding a longer timeout should be reasonable enough.