Merge pull request #5723 from nextcloud/test/jest-without-503s

fix(linkBubble): load only when needed
nextcloud · Apr 23, 2024 · b0f9ef1 · b0f9ef1
2 parents 1d767ac + 02af121
commit b0f9ef1
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/plugins/LinkBubblePluginView.js b/src/plugins/LinkBubblePluginView.js
@@ -13,14 +13,6 @@ class LinkBubblePluginView {
 		this.view = view
 		this.plugin = plugin
 		this.#editor = this.options.editor
-
-		this.#component = new VueRenderer(LinkBubbleView, {
-			parent: this.options.parent,
-			propsData: {
-				editor: this.options.editor,
-				href: null,
-			},
-		})
 	}
 
 	addEventListeners() {
@@ -32,7 +24,7 @@ class LinkBubblePluginView {
 		)
 		document.addEventListener('scroll',
 			this.closeOnExternalEvents,
-			{ capture: true }
+			{ capture: true },
 		)
 	}
 
@@ -45,7 +37,7 @@ class LinkBubblePluginView {
 		)
 		document.removeEventListener('scroll',
 			this.closeOnExternalEvents,
-			{ capture: true }
+			{ capture: true },
 		)
 	}
 
@@ -71,6 +63,14 @@ class LinkBubblePluginView {
 			return
 		}
 
+		this.#component ||= new VueRenderer(LinkBubbleView, {
+			parent: this.options.parent,
+			propsData: {
+				editor: this.options.editor,
+				href: null,
+			},
+		})
+
 		this.tippy = tippy(editorElement, {
 			duration: 100,
 			getReferenceClientRect: null,
@@ -112,7 +112,7 @@ class LinkBubblePluginView {
 		}
 		const clientRect = referenceEl?.getBoundingClientRect()
 
-		this.#component.updateProps({
+		this.#component?.updateProps({
 			href: domHref(mark),
 		})
 

diff --git a/src/tests/nodes/TaskItem.spec.js b/src/tests/nodes/TaskItem.spec.js
@@ -18,7 +18,7 @@ describe('TaskItem extension', () => {
 		expect(taskItem.spec.toMarkdown).toBeDefined()
 	})
 
-	test('markdown syntax is preserved through editor', () => {
+	it('markdown syntax is preserved through editor', () => {
 		// Invalid ones but should be syntactical unchanged
 		expect(markdownThroughEditor('- [F] asd')).toBe('- [F] asd')
 		expect(markdownThroughEditor('- [ [asd](sdf)')).toBe('- [ [asd](sdf)')