Merge pull request #6597 from nextcloud/fix/console_errors

Fix some JS console errors
nextcloud · Nov 5, 2024 · 93a1563 · 93a1563
2 parents ad08894 + 8bdf7ae
commit 93a1563
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/src/components/Assistant.vue b/src/components/Assistant.vue
@@ -47,7 +47,7 @@
 				class="floating-menu--badge" />
 		</FloatingMenu>
 
-		<NcModal :show.sync="showTaskList">
+		<NcModal :show.sync="showTaskList" :name="t('text', 'Assistant results')">
 			<div class="task-list">
 				<h4 v-if="tasks.length > 0">
 					<span class="assistant-bubble">

diff --git a/src/components/Editor.vue b/src/components/Editor.vue
@@ -176,7 +176,9 @@ export default {
 
 		return val
 	},
-	inject: ['isEmbedded'],
+	inject: {
+		isEmbedded: { default: false },
+	},
 	props: {
 		richWorkspace: {
 			type: Boolean,

diff --git a/src/components/Modal/Translate.vue b/src/components/Modal/Translate.vue
@@ -4,7 +4,10 @@
 -->
 
 <template>
-	<NcModal :show="show" size="large" @close="$emit('close')">
+	<NcModal :show="show"
+		size="large"
+		:name="t('text', 'Translate')"
+		@close="$emit('close')">
 		<div class="translate-dialog">
 			<h2>{{ t('text', 'Translate') }}</h2>
 			<em>{{ t('text', 'To translate individual parts of the text, select it before using the translate function.') }}</em>
@@ -15,6 +18,7 @@
 						<NcSelect v-model="fromLanguage"
 							input-id="fromLanguage"
 							:placeholder="t('text', 'Select language')"
+							:aria-label-combobox="t('text', 'Translate from')"
 							:options="fromLanguages"
 							:disabled="disableFromLanguageSelect"
 							:append-to-body="false" />
@@ -34,6 +38,7 @@
 						<NcSelect v-model="toLanguage"
 							input-id="toLanguage"
 							:placeholder="t('text', 'Select language')"
+							:aria-label-combobox="t('text', 'Translate to')"
 							:options="toLanguages"
 							:disabled="!fromLanguage"
 							:append-to-body="false" />
@@ -158,12 +163,12 @@ export default {
 			this.input = this.content
 		},
 		input() {
-			this.result = null
+			this.result = ''
 			this.error = null
 			this.autosize()
 		},
 		toLanguage() {
-			this.result = null
+			this.result = ''
 			this.error = null
 		},
 	},