Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support videos in media view #1844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielStandfest
Copy link
Contributor

added support for videos (and playback) when swiping in media view.

Closes #1702

@SystemKeeper

@SystemKeeper
Copy link
Collaborator

Very cool @DanielStandfest, thanks a lot for working on this 👍
We are going to take a look at this in the upcoming week.

Btw, we can add you to the Nextcloud org if you like? Then you can directly push here. We also have a developer chat where we can create a guest account for you, if you like. Just let me know :)

@DanielStandfest
Copy link
Contributor Author

Thank you @SystemKeeper.
Sure, would be nice to be added :)

Appreciate it.

@SystemKeeper
Copy link
Collaborator

The warning about the branch being out of date is usually not an issue, it's just a warning. If merging would not be possible
you would see a message like:
image

Since we pull in latest translation changes at least once a day, it's very likely that your branch becomes outdated quite quickly.

If you wanna update the branch to be inline with latest master, you can use the rebase option to prevent unnecessary merge commits btw:
image

Closes nextcloud#1702

Signed-off-by: Daniel Standfest <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support videos in media view
2 participants