Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Edit last message hotkey on macOS #13658

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 29, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme added 3. to review bug feature: chat 💬 Chat and system messages labels Oct 29, 2024
@ShGKme ShGKme added this to the 🖤 Next Major (31) milestone Oct 29, 2024
@ShGKme ShGKme self-assigned this Oct 29, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 29, 2024

/backport to stable30

src/components/NewMessage/NewMessage.vue Show resolved Hide resolved
* Per-OS flags
*/

export const isMac = os.name === 'Mac OS'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update in the meantime?
https://docs.uaparser.dev/intro/whats-new.html#version-2-0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's follow-up, if you don't want to mix PRs

Signed-off-by: Grigorii K. Shartsev <[email protected]>
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows (at least it's confirmed that it remains working for Win :') )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants