Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move EventBus to TS #13650

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore: move EventBus to TS #13650

merged 1 commit into from
Oct 29, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix typings for once method

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

		EventBus.once('*', (...args) => {
			console.log('wild once', ...args)
		})

		EventBus.on('*', (...args) => {
			console.log('wild on', ...args)
		})

image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

Signed-off-by: Maksim Sukharev <[email protected]>
@ShGKme
Copy link
Contributor

ShGKme commented Oct 29, 2024

ShGKme force-pushed

Branch mismatch, push and dropped back

@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit 6908891 into main Oct 29, 2024
91 checks passed
@Antreesy Antreesy deleted the fix/noid/event-bus-ts branch October 29, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants