Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e-mail guests - frontend 📧 (part 1) #13633

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix: e-mail guests - frontend 📧 (part 1) #13633

merged 3 commits into from
Oct 29, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 25, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image

🚧 Tasks

  • Show account icon for both moderators and users (👤, no questionmark anymore, should be the same as for former-one-to-one)
  • Show first letter when a custom name is set
  • Only show email icon for moderators when searching / adding a new participant (invite e-mail)
  • Show always (guest) badge
  • Show always on grey background
  • Show the invited email address to moderators in the participants list
  • Resending the invite shows the ID instead of the name

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 25, 2024
@Antreesy Antreesy self-assigned this Oct 25, 2024
@Antreesy Antreesy force-pushed the feat/13606/email-guests-frontend branch 2 times, most recently from c31b20c to 094eebb Compare October 25, 2024 20:12
DorraJaouad
DorraJaouad approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good

src/components/RightSidebar/Participants/Participant.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/13606/email-guests-frontend branch from 71d3ece to cf76460 Compare October 28, 2024 13:16
@DorraJaouad
Copy link
Contributor

  • The mail address is shown for moderators in the callview and message sender (like it's done for federated users)

Will this be in a follow-up?

DorraJaouad
DorraJaouad approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found, tested and works as planned.

src/components/AvatarWrapper/AvatarWrapper.vue Outdated Show resolved Hide resolved
@Antreesy
fix: show first letter for e-mail guests avatars
3b644d1 
- show mail icon for default name
- refactor tests

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: show guest badge for e-mail guests
7cc8755 
- refactor tests

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: show e-mail in subline of e-mail guests for moderators
9698c34 
- show e-mail in toast when resend invitation
- refactor tests

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the feat/13606/email-guests-frontend branch from cf76460 to 9698c34 Compare October 29, 2024 15:16
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit b751e6a into main Oct 29, 2024
46 checks passed
@Antreesy Antreesy deleted the feat/13606/email-guests-frontend branch October 29, 2024 15:55
@backportbot backportbot bot mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad