-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PublicShareSidebar for Nextcloud 31 #13628
Conversation
Failing sharing tests are unrelated and fixed by #13632 |
2e58fa4
to
1d675ee
Compare
In the frontend just use |
c2a900b
to
fad342b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 🦅
Signed-off-by: Maksim Sukharev <[email protected]>
- replace NcButton with NcHeaderButton - move to script setup TS - adjust mountpoint to .header-end Signed-off-by: Maksim Sukharev <[email protected]>
- wrap mounting in function - adjust shareToken receiving to server API - adjust mountpoint to #content-vue Signed-off-by: Maksim Sukharev <[email protected]>
- remove publicshare.css as redundant - keep footer in place, adjust width if talk sidebar is open Signed-off-by: Maksim Sukharev <[email protected]>
fad342b
to
f538f9a
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist