Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calls): Add appconfig and user preference for default setting of… #13488

Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat(calls): Add appconfig and user preference for default setting of… #13488

merged 1 commit into from
Oct 8, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 7, 2024 •
edited by Antreesy
Loading

… media

☑️ Resolves

🛠️ API Checklist

⚙️ Settings API

The endpoint for actually setting it is in the provisioning API:
if you have ocs_api_viewer installed: /index.php/apps/ocs_api_viewer/view/provisioning_api#/operations/preferences-set-preference
grafik

Sample:

POST /ocs/v2.php/apps/provisioning_api/api/v1/config/users/{appId}/{configKey}
{"configValue":"yes|no"}

POST /ocs/v2.php/apps/provisioning_api/api/v1/config/users/spreed/play_sounds
{"configValue":"no"}

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review enhancement feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls labels Oct 7, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Oct 7, 2024
@nickvergessen nickvergessen self-assigned this Oct 7, 2024
@nickvergessen nickvergessen mentioned this pull request Oct 7, 2024
Closed
2 tasks
@nickvergessen nickvergessen force-pushed the feat/13446/api-for-media-preference branch from bd1c758 to a7c0f3b Compare October 7, 2024 14:09
@DorraJaouad DorraJaouad force-pushed the feat/13446/api-for-media-preference branch from ec3c57d to 3453115 Compare October 8, 2024 07:40
@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen nickvergessen mentioned this pull request Oct 8, 2024
Merged
6 tasks
Antreesy
Antreesy reviewed Oct 8, 2024
View reviewed changes
src/__mocks__/capabilities.ts Show resolved Hide resolved
lib/Config.php Outdated Show resolved Hide resolved
Antreesy
Antreesy approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
image

@nickvergessen nickvergessen force-pushed the feat/13446/api-for-media-preference branch from 0458d0d to af917bc Compare October 8, 2024 12:05
DorraJaouad
DorraJaouad approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@nickvergessen nickvergessen merged commit ac44f1d into main Oct 8, 2024
69 checks passed
@nickvergessen nickvergessen deleted the feat/13446/api-for-media-preference branch October 8, 2024 12:21
@backportbot backportbot bot mentioned this pull request Oct 8, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: settings ⚙️ Settings and config related issues
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @DorraJaouad @Antreesy