Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breakout-rooms): enforce rooms order, minor fixes #12201

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Apr 24, 2024

☑️ Resolves

  • Fix Breakout rooms mixed up in participants editor #11921
    • sort rooms in getter by id (order of creation, so 1 -> 2 -> 3) hard to reproduce
    • use server-provided room names where possible ParticipantsEditor
    • ease template in Vue SFC files
    • add some ?. conditions to avoid TypeErrors Vue devtools
    • fix styles to avoid double scrollbar in dialogs screenshot
    • don't mount NcDialog for deletion if not called explicitly console

TODO:

  • find another way to restrict image sizes (now it affects user_status)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💙 Next Major (30) milestone Apr 24, 2024
@Antreesy Antreesy self-assigned this Apr 24, 2024
@Antreesy Antreesy changed the title fix(breakout-rooms): fix(breakout-rooms): enforce rooms order, minor fixes Apr 24, 2024
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better format

.participants-editor__buttons {
	padding-top: 10px;

.breakout-rooms-actions__editor {
	padding: 20px 20px 5px;
}

@Antreesy Antreesy force-pushed the fix/11921/breakout-rooms-fix branch from 677ab86 to 51b56e4 Compare April 25, 2024 08:58
@Antreesy Antreesy merged commit 3e6e3bf into main Apr 25, 2024
45 checks passed
@Antreesy Antreesy deleted the fix/11921/breakout-rooms-fix branch April 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakout rooms mixed up in participants editor
3 participants