-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(breakout-rooms): enforce rooms order, minor fixes #12201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
bug
feature: frontend 🖌️
"Web UI" client
feature: breakout rooms 🖖
labels
Apr 24, 2024
Antreesy
changed the title
fix(breakout-rooms):
fix(breakout-rooms): enforce rooms order, minor fixes
Apr 24, 2024
src/components/BreakoutRoomsEditor/BreakoutRoomsParticipantsEditor.vue
Outdated
Show resolved
Hide resolved
DorraJaouad
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better format
.participants-editor__buttons {
padding-top: 10px;
.breakout-rooms-actions__editor {
padding: 20px 20px 5px;
}
…om 1 to N) Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/11921/breakout-rooms-fix
branch
from
April 24, 2024 14:52
8700a0b
to
677ab86
Compare
DorraJaouad
approved these changes
Apr 25, 2024
…y when needed Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/11921/breakout-rooms-fix
branch
from
April 25, 2024 08:58
677ab86
to
51b56e4
Compare
DorraJaouad
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
TODO:
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist