Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Don't double convert the actor info in the last message #11942

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

nickvergessen
Copy link
Member

The PCM cache is already converted, so converting again on rendering, would create a conflict if there is a user1 from host and proxy in the room.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

The PCM cache is already converted, so converting again on rendering,
would create a conflict if there is a user1 from host and proxy in the room.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Mar 27, 2024
@nickvergessen nickvergessen added this to the 💞 Next RC (29) milestone Mar 27, 2024
@nickvergessen nickvergessen self-assigned this Mar 27, 2024
@nickvergessen nickvergessen merged commit 7803a5f into main Mar 27, 2024
64 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/dont-double-convert branch March 27, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants