Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(MessagesList): Refactor scrolling #11934

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Mar 26, 2024

Includes

  • Restrict Placeholder to not to create scrolling for the chat when it is there
  • Message Highlight is event-driven now instead of ref-oriented, saves some computations
  • Adjust fallback visible message to include only actual visible messages (e.g: not reaction system messages)

Follow-up:

  • Removed extra steps in scrolling and improved remaining.

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
src/store/messagesStore.js Show resolved Hide resolved
@DorraJaouad DorraJaouad merged commit 0afabde into main Mar 27, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/focusing-on-message branch March 27, 2024 11:12
@nextcloud nextcloud deleted a comment from backportbot bot Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: chat 💬 Chat and system messages technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants