-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MessagesList): Fix chat jumping on reference widgets #11844
Conversation
Signed-off-by: DorraJaouad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more time to check, how it would behave, and what it could fix. We probably should reverse groups too
:previous-message-id="group.previousMessageId" | ||
:next-message-id="group.nextMessageId" /> | ||
</ul> | ||
<div class="messages-list-wrapper__reversed"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just apply these styles to 'scroller' class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it will put unscrollable list ( messages that do no exceed the view) at the bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should reverse groups too
I would yes, it will be good but it's not critical to change atm (usually groups are short around 4 to 5 messages).
and please let's keep this for fixing reference widgets jumping only here. Otherwise, it will be huge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very unsure about this. Also seeing the internal reports with people having 10 files locked with text because they opened a talk room and the widget stealing the focus while typing a message, make me prefer an "opt out" of the widgets :-/
also turning around the loading order will not work for the context load and basically it will immediately jump to the end marking everything read?
All occurences and triggers of
Was added just in case 4 years ago, not sure we still need it?
check if messages are in DOM?
Keep only one scroll method (with optional smooth, ifSticky, e.t.c.)?,
replace both with "after messages array changed" in watcher? Would it also make sense to store previous scroll value per chat (chatIdentifier), to avoid jumping when switch? |
It's wrong anyway because it can contain unread messages and it should scroll to the last read message not the bottom. It's not impacting it now as
Yes, better
Yes, it will skip scrolling in vain where polling didn't add more messages, just need to check for reactions if computed prop watcher can detect its changes or not. I would centralize all scrolling process in one method
|
Let's wait for the result of nextcloud/text#5532 (comment) |
It doesn't work anymore with the new changes :') |
☑️ Resolves
However, a few things to look into them soon:
handleStartGettingMessagesPreconditions
andhandleScroll
are the roots of each process -> can be improved.🖌️ UI Checklist
b/ Load the conversation from switching conversations
🏁 Checklist