Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pinia): migrate breakoutRoomsStore to Pinia 🍍 #11649

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 25, 2024

  • Migrate breakoutRoomsStore to Pinia 🍍
    • optimize some methods
    • rename **Action to normal ones

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

No visual changes

🚧 Tasks

  • Pinia migration
  • Typescript migration - in follow-up
  • Test coverage - in follow-up

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing :
image
Participants are not in their right room.

Also, is it expected to return room-not-found when reassigning a participant to the room where you are currently joining the call?

src/stores/breakoutRooms.js Outdated Show resolved Hide resolved
src/stores/breakoutRooms.js Outdated Show resolved Hide resolved
src/stores/breakoutRooms.js Outdated Show resolved Hide resolved
src/stores/breakoutRooms.js Outdated Show resolved Hide resolved
@Antreesy

This comment was marked as off-topic.

@DorraJaouad

This comment was marked as off-topic.

@Antreesy

This comment was marked as off-topic.

@Antreesy Antreesy force-pushed the refactor/noid/migrate-breakout-store branch from fabb220 to 0b7330a Compare March 25, 2024 11:24
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As follow-ups are there, this is ready

@Antreesy Antreesy merged commit 38a03ec into main Mar 25, 2024
46 checks passed
@Antreesy Antreesy deleted the refactor/noid/migrate-breakout-store branch March 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants