fix(settings): Correctly parse and display default quota #50187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
susnux
requested review from
Pytal,
a team,
nfebe and
sorbaugh
and removed request for
a team
|
/backport to stable30 |
Pytal
approved these changes
Jan 14, 2025
Merged
artonge
approved these changes
Jan 16, 2025
In the account management settings (default settings) the quota was parsed not consistently with how we do it everywhere else. Meaning `1 KB` should be 1024 bytes not 1000 bytes. Also this fixes an issue where searching "1KB" does not yield any output because of the space in the parsed value "1 KB". Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/account-mgmnt-settings
branch
from
5f98df8 to
26fd7a0
Compare
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the account management settings (default settings) the quota was parsed not consistently with how we do it everywhere else. Meaning
1 KBshould be 1024 bytes not 1000 bytes.Also this fixes an issue where searching "1KB" does not yield any output because of the space in the parsed value "1 KB".