refactor(files): Provide useFileListWidth composable
#49305
+115
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
Replace the mixin with a composable, this is better typed and works in both: Options- and Composition API. Also added component tests for it. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
refactor/files-filelist-width
branch
from
2c81114
to
7169dd6
Compare
skjnldsv
approved these changes
Nov 15, 2024
ShGKme
reviewed
Nov 15, 2024
Comment on lines
+9
to
+20
| /** | ||
| * Get the reactive width of the file list | ||
| */ | ||
| export function useFileListWidth(): Readonly<Ref<number>> { | ||
| const element = ref(document.querySelector<HTMLElement>('#app-content-vue') ?? document.body) | ||
| onMounted(() => { element.value = document.querySelector('#app-content-vue')! }) | ||
|
|
||
| const { width, stop } = useElementSize(element) | ||
| onUnmounted(stop) | ||
|
|
||
| return width | ||
| } |
There was a problem hiding this comment.
Let's do it with as a shared composable for performance.
Otherwise 10 component instances using this composable means creating 10 * reactive variables + 10 resize observers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the mixin with a composable, this is better typed and works in both: Options- and Composition API.
Also added component tests for it.
Checklist