[stable29] fix: override iTip Broker to fix several issues #49270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
requested review from
ChristophWurst,
st3iny and
SebastianKrupinski
kesselb
approved these changes
Nov 14, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $icalMsg = new VCalendar(); | ||
|
|
||
| foreach ($calendar->select('VTIMEZONE') as $timezone) { | ||
| $icalMsg->add(clone $timezone); |
Check notice
Code scanning / Psalm
MixedClone Note
| // the attendee was removed and we need to send them a CANCEL message. | ||
| // Also If the meeting STATUS property was changed to CANCELLED | ||
| // we need to send the attendee a CANCEL message. | ||
| if (!$attendee['newInstances'] || $eventInfo['status'] === 'CANCELLED') { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison Note
| $message->method = $icalMsg->METHOD = 'CANCEL'; | ||
| $message->significantChange = true; | ||
| // clone base event | ||
| $event = clone $eventInfo['instances']['master']; |
Check notice
Code scanning / Psalm
MixedClone Note
| $oldEventInfo['significantChangeHash'] !== $eventInfo['significantChangeHash']; | ||
|
|
||
| foreach ($attendee['newInstances'] as $instanceId => $instanceInfo) { | ||
| $currentEvent = clone $eventInfo['instances'][$instanceId]; |
Check notice
Code scanning / Psalm
MixedClone Note
SebastianKrupinski
force-pushed
the
backport/48583/stable29
branch
from
6888528
to
636d24a
Compare
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
backport/48583/stable29
branch
from
636d24a
to
106d9ea
Compare
kesselb
approved these changes
Nov 14, 2024
SebastianKrupinski
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48583
Requires: #49266
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.