fix(files_external): cast storage id int #49218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
requested review from
nfebe,
yemkareems and
provokateurin
and removed request for
a team
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
provokateurin
approved these changes
Nov 12, 2024
nfebe
approved these changes
Nov 12, 2024
skjnldsv
added
4. to release
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
"OCA\\Files_External\\Service\\DBConfigService::getMountById(): Argument #1 ($mountId) must be of type int, string givenDo we need strict typing on this? 🤔
{ "Exception": "TypeError", "Message": "OCA\\Files_External\\Service\\DBConfigService::getMountById(): Argument #1 ($mountId) must be of type int, string given, called in /var/www/html/nextcloud_test1/apps/files_external/lib/Service/StoragesService.php on line 164", "Code": 0, "Trace": [ { "file": "/var/www/html/nextcloud_test1/apps/files_external/lib/Service/StoragesService.php", "line": 164, "function": "getMountById", "class": "OCA\\Files_External\\Service\\DBConfigService", "type": "->" }, { "file": "/var/www/html/nextcloud_test1/apps/files_external/lib/Controller/StoragesController.php", "line": 296, "function": "getStorage", "class": "OCA\\Files_External\\Service\\StoragesService", "type": "->" }, { "file": "/var/www/html/nextcloud_test1/apps/files_external/lib/Controller/UserStoragesController.php", "line": 110, "function": "show", "class": "OCA\\Files_External\\Controller\\StoragesController", "type": "->" }, { "file": "/var/www/html/nextcloud_test1/lib/private/AppFramework/Http/Dispatcher.php", "line": 230, "function": "show", "class": "OCA\\Files_External\\Controller\\UserStoragesController", "type": "->" }, {...} }