fix(ros): Copy better typing information from Notifications/Spreed app

[nickvergessen]

Fixes failing Talk and Notification psalm in a better way than nextcloud/notifications@5cf07bd

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[provokateurin]

We could do this even better, by creating the exact types from

server/lib/public/RichObjectStrings/Definitions.php

Line 18 in 23071c7

public $definitions = [

like this:

/**
 * @psalm-type RichObjectParameterAddressbook = array{
 *     id: string,
 *     type: string,
 *     name: string,
 * }
 *
 * @psalm-type RichObjectParameterAnnouncement = array{
 *     id: string,
 *     type: string,
 *     name: string,
 *     link?: string,
 * }
 *
 * @psalm-type RichObjectParameter = RichObjectParameterAddressbook|RichObjectParameterAnnouncement
 */

Of course this would be with all types, not just these ones.
Then every consumer knows exactly what they can use, because even with this annotation psalm will not yet prevent you from adding keys that are for a different object type.

We could have a script for this to ensure the psalm types match the definitions and then also make it available as a type for OpenAPI.
Maybe this is a bit overkill

[nickvergessen]

Maybe this is a bit overkill

Glad you noticed it yourself :P

[provokateurin]

Well I have written this exact logic for a different use-case already, so it's not completely out of reach, just wanted to mention it would be possible to make it even stricter.