fix(files): open sidebar on sharing tab by default for files

apps/files/src/actions/sidebarAction.spec.ts

@@ -2,7 +2,7 @@
  * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-import { File, Permission, View, FileAction } from '@nextcloud/files'
+import { File, Permission, View, FileAction, Folder } from '@nextcloud/files'
 import { describe, expect, test, vi } from 'vitest'
 
 import { action } from './sidebarAction'
@@ -108,7 +108,9 @@ describe('Open sidebar action enabled tests', () => {
 describe('Open sidebar action exec tests', () => {
 	test('Open sidebar', async () => {
 		const openMock = vi.fn()
-		window.OCA = { Files: { Sidebar: { open: openMock } } }
+		const defaultTabMock = vi.fn()
+		window.OCA = { Files: { Sidebar: { open: openMock, setActiveTab: defaultTabMock } } }
+
 		const goToRouteMock = vi.fn()
 		// @ts-expect-error We only mock what needed, we do not need Files.Router.goTo or Files.Navigation
 		window.OCP = { Files: { Router: { goToRoute: goToRouteMock } } }
@@ -124,6 +126,36 @@ describe('Open sidebar action exec tests', () => {
 		// Silent action
 		expect(exec).toBe(null)
 		expect(openMock).toBeCalledWith('/foobar.txt')
+		expect(defaultTabMock).toBeCalledWith('sharing')
+		expect(goToRouteMock).toBeCalledWith(
+			null,
+			{ view: view.id, fileid: '1' },
+			{ dir: '/' },
+			true,
+		)
+	})
+
+	test('Open sidebar for folder', async () => {
+		const openMock = vi.fn()
+		const defaultTabMock = vi.fn()
+		window.OCA = { Files: { Sidebar: { open: openMock, setActiveTab: defaultTabMock } } }
+
+		const goToRouteMock = vi.fn()
+		// @ts-expect-error We only mock what needed, we do not need Files.Router.goTo or Files.Navigation
+		window.OCP = { Files: { Router: { goToRoute: goToRouteMock } } }
+
+		const file = new Folder({
+			id: 1,
+			source: 'https://cloud.domain.com/remote.php/dav/files/admin/foobar',
+			owner: 'admin',
+			mime: 'httpd/unix-directory',
+		})
+
+		const exec = await action.exec(file, view, '/')
+		// Silent action
+		expect(exec).toBe(null)
+		expect(openMock).toBeCalledWith('/foobar')
+		expect(defaultTabMock).toBeCalledWith('sharing')
 		expect(goToRouteMock).toBeCalledWith(
 			null,
 			{ view: view.id, fileid: '1' },
@@ -134,7 +166,8 @@ describe('Open sidebar action exec tests', () => {
 
 	test('Open sidebar fails', async () => {
 		const openMock = vi.fn(() => { throw new Error('Mock error') })
-		window.OCA = { Files: { Sidebar: { open: openMock } } }
+		const defaultTabMock = vi.fn()
+		window.OCA = { Files: { Sidebar: { open: openMock, setActiveTab: defaultTabMock } } }
 		vi.spyOn(logger, 'error').mockImplementation(() => vi.fn())
 
 		const file = new File({

apps/files/src/actions/sidebarAction.ts

@@ -44,6 +44,9 @@ export const action = new FileAction({
 
 	async exec(node: Node, view: View, dir: string) {
 		try {
+			// Open sidebar and set active tab to sharing by default
+			window.OCA.Files.Sidebar.setActiveTab('sharing')
+
 			// TODO: migrate Sidebar to use a Node instead
 			await window.OCA.Files.Sidebar.open(node.path)
 

apps/files_sharing/src/components/SharingEntryLink.vue

@@ -596,8 +596,10 @@ export default {
 		},
 	},
 	mounted() {
-		this.defaultExpirationDateEnabled = this.config.defaultExpirationDate instanceof Date
-		this.share.expireDate = this.defaultExpirationDateEnabled ? this.formatDateToString(this.config.defaultExpirationDate) : ''
+		if (this.share) {
+			this.defaultExpirationDateEnabled = this.config.defaultExpirationDate instanceof Date
+			this.share.expireDate = this.defaultExpirationDateEnabled ? this.formatDateToString(this.config.defaultExpirationDate) : ''
+		}
 	},
 
 	methods: {

cypress/e2e/files_sharing/files-inline-action.cy.ts

@@ -29,7 +29,7 @@ describe('files_sharing: Files inline status action', { testIsolation: true }, (
 			.should('not.exist')
 	})
 
-	describe('', () => {
+	describe('Sharing inline status action handling', () => {
 		let user: User
 		let sharee: User
 

dist/1417-1417.js.map.license

@@ -0,0 +1 @@
+1417-1417.js.license