fix(apps-store): Remove apps from force-enabled state when uninstalled #48855
+34
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
icewind1991,
nfebe,
sorbaugh and
artonge
and removed request for
a team
susnux
force-pushed
the
fix/app-store-remove-force-enable
branch
from
d7fcbc2
to
cb45a3b
Compare
susnux
requested review from
provokateurin and
come-nc
and removed request for
icewind1991 and
sorbaugh
susnux
force-pushed
the
fix/app-store-remove-force-enable
branch
from
cb45a3b
to
430bdc7
Compare
provokateurin
requested changes
Oct 29, 2024
provokateurin
approved these changes
Oct 29, 2024
come-nc
reviewed
Nov 4, 2024
susnux
force-pushed
the
fix/app-store-remove-force-enable
branch
from
430bdc7
to
64bd769
Compare
skjnldsv
approved these changes
Nov 11, 2024
susnux
force-pushed
the
fix/app-store-remove-force-enable
branch
from
64bd769
to
f185c67
Compare
If an app is force-enabled and then uninstalled the force-enabled state was kept. This is now removed, so when the app should be re-installed the compatibility should be reevaluated. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/app-store-remove-force-enable
branch
from
f185c67
to
1cf2bbc
Compare
come-nc
requested changes
Nov 12, 2024
Comment on lines
+595
to
+598
| $appManager = $this->appManager; | ||
| // If this app was force enabled, remove the force-enabled-state | ||
| $appManager->removeOverwriteNextcloudRequirement($appId); | ||
| $appManager->clearAppsCache(); |
There was a problem hiding this comment.
Suggested change
| $appManager = $this->appManager; | |
| // If this app was force enabled, remove the force-enabled-state | |
| $appManager->removeOverwriteNextcloudRequirement($appId); | |
| $appManager->clearAppsCache(); | |
| // If this app was force enabled, remove the force-enabled-state | |
| $this->appManager->removeOverwriteNextcloudRequirement($appId); | |
| $this->appManager->clearAppsCache(); |
Comment on lines
+636
to
+640
| /** @var \OC\App\AppManager $appManager */ | ||
| $appManager = $this->appManager; | ||
|
|
||
| $appId = $appManager->cleanAppId($appId); | ||
| $appManager->overwriteNextcloudRequirement($appId); |
There was a problem hiding this comment.
Suggested change
| /** @var \OC\App\AppManager $appManager */ | |
| $appManager = $this->appManager; | |
| $appId = $appManager->cleanAppId($appId); | |
| $appManager->overwriteNextcloudRequirement($appId); | |
| $appId = $this->appManager->cleanAppId($appId); | |
| $this->appManager->overwriteNextcloudRequirement($appId); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If an app is force-enabled and then uninstalled the force-enabled state was kept. This is now removed, so when the app should be re-installed the compatibility should be reevaluated.
Checklist