Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(psalm): Enable findUnusedBaselineEntry #48266

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

provokateurin
Copy link
Member

Summary

The PRs of the workflows are rarely merged and make it more complicated than necessary to manage the baseline. This option will force everyone to remove the baseline entries they fixed.

Checklist

@provokateurin provokateurin added the 3. to review Waiting for reviews label Sep 22, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Sep 22, 2024
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨 🔨

@provokateurin provokateurin force-pushed the fix/psalm/enabled-find-unused-baseline-entry branch from d504a38 to 6fd1799 Compare September 23, 2024 07:15
@provokateurin provokateurin merged commit ba41f32 into master Sep 23, 2024
176 checks passed
@provokateurin provokateurin deleted the fix/psalm/enabled-find-unused-baseline-entry branch September 23, 2024 07:41
Copy link

backportbot bot commented Sep 23, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/48266/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6fd17994

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48266/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Sep 23, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/48266/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6fd17994

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48266/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Sep 23, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/48266/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6fd17994

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/48266/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants