Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(settings): align icons at legacy help navigation #46773

Merged
merged 1 commit into from
Jul 26, 2024
Merged

style(settings): align icons at legacy help navigation #46773

merged 1 commit into from
Jul 26, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 26, 2024 •
edited
Loading

Summary

Before After
image image

Checklist

@Antreesy Antreesy added this to the Nextcloud 30 milestone Jul 26, 2024
@Antreesy Antreesy self-assigned this Jul 26, 2024
@szaimen
Copy link
Contributor

szaimen commented Jul 26, 2024

image
From this screenshot, I'd say that the list items could use a bit of styling, e.g. adding some margins and padding and increase the height of each item... But fine from my side if the customer is fine if the icons are aligned properly...

@Antreesy Antreesy force-pushed the fix/noid/settings-iframe-icons branch from ae5149f to 0dc4ed1 Compare July 26, 2024 11:11
@Antreesy
Copy link
Contributor Author

Yeah, I did just the bare minimum to move them. Added a bit of space around, hope that should be sufficient

szaimen
szaimen approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now imo, thanks for adjusting :)

@Antreesy Antreesy merged commit 602ef72 into master Jul 26, 2024
167 checks passed
@Antreesy Antreesy deleted the fix/noid/settings-iframe-icons branch July 26, 2024 16:15
@Antreesy
Copy link
Contributor Author

/backport to stable29

@Antreesy
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jul 26, 2024
Merged
@backportbot backportbot bot mentioned this pull request Jul 26, 2024
Merged
@blizzz blizzz mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug feature: settings
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @szaimen @susnux