-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Navigate via folder tree #46596
Conversation
68ea1ba
to
662d3ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments to be addresses later 👍
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Congrats 🎉 🎉 🎉 |
The
|
Finally this shortcut works for me. What exactly should the code called in function "getFolderTree()" be doing? - Implement the new feature side bar? |
We are working on optimizing this feature @frake65, though the page might be too unresponsive with very large trees there is an "Enable folder tree" checkbox located in the Files settings dialog which can be toggled per-user and will prevent the endpoint from being called completely |
I did remove the shortcut and now I'm using the toggle switch. - Thank you for pointing me there!
In my opinion probably this feature should be postponed |
Summary
Split commits for easier reviewing :)
Checklist