-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): implement config lexicon #44371
Open
ArtificialOwl
wants to merge
5
commits into
master
Choose a base branch
from
feature/noid/wrapped-appconfig
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5,147
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
from
March 21, 2024 00:35
f374de6
to
b7c0296
Compare
ArtificialOwl
added
1. to develop
Accepted and waiting to be taken care of
2. developing
Work in progress
enhancement
labels
Mar 21, 2024
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
from
March 22, 2024 00:21
b7c0296
to
eee62ee
Compare
ArtificialOwl
changed the title
feat(config): frame config keys/values
feat(config): implement config lexicon
Apr 3, 2024
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
from
April 3, 2024 17:14
837a165
to
e49c1a5
Compare
ChristophWurst
added
the
pending documentation
This pull request needs an associated documentation update
label
Apr 8, 2024
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
from
April 22, 2024 12:22
e49c1a5
to
c0eb002
Compare
ArtificialOwl
added
3. to review
Waiting for reviews
and removed
1. to develop
Accepted and waiting to be taken care of
2. developing
Work in progress
labels
Apr 22, 2024
ArtificialOwl
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Apr 22, 2024
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
from
April 22, 2024 17:36
c0eb002
to
1eb6edc
Compare
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
from
April 22, 2024 19:27
1eb6edc
to
923d52a
Compare
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
2 times, most recently
from
April 23, 2024 00:28
7ac3ee4
to
161314f
Compare
ArtificialOwl
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Apr 24, 2024
ArtificialOwl
requested review from
a team,
icewind1991,
yemkareems,
sorbaugh,
artonge and
come-nc
and removed request for
a team
April 24, 2024 08:35
come-nc
reviewed
Apr 30, 2024
Merged
skjnldsv
added
2. developing
Work in progress
stale
Ticket or PR with no recent activity
and removed
3. to review
Waiting for reviews
labels
Aug 6, 2024
Merged
Merged
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
from
October 1, 2024 15:50
899b6fc
to
e2e345d
Compare
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
3 times, most recently
from
November 13, 2024 10:19
05c5e81
to
725f11d
Compare
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
feature/noid/wrapped-appconfig
branch
from
November 15, 2024 09:13
9f5b8d3
to
a9051c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Work in progress
enhancement
pending documentation
This pull request needs an associated documentation update
stale
Ticket or PR with no recent activity
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Config Lexicon
is a list of config keys used by current app. Each entry also define the expected type for the config value, its lazyness/sensitivity.The loading is done by registering a
IConfigLexicon
.Application.php
ConfigLexicon.php
Note: A description of the config key can be added as 3rd parameter of the
ConfigLexiconEntry
. This information is not stored when running from a web process.store and retrieve config value
Once this is done:
any code trying to wrongly type config values will get an exception
set/get on config values set as lazy will work even if not specified in the process
default value can be overwritten
will returns
42
If configured as
strict
, setting an unlisted config values returns an exceptionAlso, setting a config key as deprecated will generate a level 1 log entry when the config key is used