feat: Add X-NC-Disable-Scheduling property to allow skipping scheduling

Signed-off-by: SebastianKrupinski <[email protected]>
nextcloud · Nov 11, 2024 · 591a20d · 591a20d
1 parent 60b6840
commit 591a20d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php b/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php
@@ -97,7 +97,7 @@ public function beforeWriteContent($uri, INode $node, $data, $modified): void {
 	public function schedule(Message $iTipMessage) {
 
 		// do not send imip messages if external system already did
-		if ($iTipMessage->message?->VEVENT?->{'X-NC-DISABLE-SCHEDULING'}?->getValue() === '1') {
+		if ($iTipMessage->message?->VEVENT?->{'X-NC-DISABLE-SCHEDULING'}?->getValue() === 'true') {
 			if (!$iTipMessage->scheduleStatus) {
 				$iTipMessage->scheduleStatus = '1.0;We got the message, but iMip message are disabled for this event';
 			}

diff --git a/apps/dav/tests/unit/CalDAV/Schedule/IMipPluginTest.php b/apps/dav/tests/unit/CalDAV/Schedule/IMipPluginTest.php
@@ -898,7 +898,7 @@ public function testImipDisabledForEvent(): void {
 		$event = $calendar->VEVENT;
 		$event->add('ORGANIZER', 'mailto:[email protected]');
 		$event->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE',  'CN' => 'Frodo']);
-		$event->add('X-NC-DISABLE-SCHEDULING', '1');
+		$event->add('X-NC-DISABLE-SCHEDULING', 'true');
 		$message = new Message();
 		$message->method = 'REQUEST';
 		$message->message = $calendar;
@@ -907,6 +907,6 @@ public function testImipDisabledForEvent(): void {
 		$message->recipient = 'mailto:' . '[email protected]';
 
 		$this->plugin->schedule($message);
-		$this->assertEquals('1.0', $message->getScheduleStatus());
+		$this->assertEquals('1.0;We got the message, but iMip message are disabled for this event', $message->scheduleStatus);
 	}
 }