Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add user settings #2795

Merged
merged 12 commits into from
Oct 17, 2024
Merged

fix: add user settings #2795

merged 12 commits into from
Oct 17, 2024

Conversation

wofferl
Copy link
Contributor

@wofferl wofferl commented Oct 3, 2024

Summary

Things that are still missing here:

  • mark as read on scroll feature is not yet implemented
  • import/export feeds and articles

Checklist

@wofferl wofferl marked this pull request as draft October 5, 2024 13:50
@wofferl wofferl marked this pull request as ready for review October 5, 2024 15:18
lib/Listeners/UserSettingsListener.php Outdated Show resolved Hide resolved
lib/Controller/PageController.php Outdated Show resolved Hide resolved
@Grotax
Copy link
Member

Grotax commented Oct 14, 2024

Needs a rebase :)

@Grotax Grotax force-pushed the user_settings branch 3 times, most recently from ff1479b to 42f449d Compare October 14, 2024 09:07
@Grotax
Copy link
Member

Grotax commented Oct 14, 2024

I can't fix the frontend tests :)

@wofferl
Copy link
Contributor Author

wofferl commented Oct 14, 2024

ah, I see some problems. I will look into it later tonight
But there are also errors on master when running make js-test or did the github action filter out some of these errors?

@Grotax
Copy link
Member

Grotax commented Oct 14, 2024

Not sure I have not much insight into the frontend tests

@wofferl
Copy link
Contributor Author

wofferl commented Oct 14, 2024

Not sure I have not much insight into the frontend tests

This seems a problem with my develop system that throws several TypeError: _vm.t is not a function when running tests.

Copy link
Contributor Author

@wofferl wofferl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to do anything else here?

@SMillerDev
Copy link
Contributor

This branch cannot be rebased due to conflicts

wofferl and others added 12 commits October 17, 2024 08:49
Signed-off-by: Wolfgang <[email protected]>
The backend sends the items to the frontend in packets of 40 sorted by item id.
In the unread, all articles or folder view this leads to the fact that new items that have been loaded can also be sorted above the items already displayed.

Signed-off-by: Wolfgang <[email protected]>
Co-authored-by: Sean Molenaar <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
add changelog entry

Signed-off-by: Wolfgang <[email protected]>
Signed-off-by: Benjamin Brahmer <[email protected]>
Signed-off-by: Benjamin Brahmer <[email protected]>
Signed-off-by: Wolfgang <[email protected]>
@SMillerDev SMillerDev merged commit 22cdb3c into nextcloud:master Oct 17, 2024
22 of 24 checks passed
Grotax added a commit that referenced this pull request Oct 19, 2024
Fixed
- First features for user settings after vue migration (#2795)
- scroll stops after first bunch of items when they are marked read during scroll (#2814)
- marked read items disappear when showAll is disabled in folder or feed view (#2814)
- Feed item lists are merged when filtered (#2516)
- Mark as read on Scroll (#2503)
- Open news with the last viewed feed or folder (#2507)

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax mentioned this pull request Oct 19, 2024
@wofferl wofferl mentioned this pull request Oct 19, 2024
19 tasks
Grotax added a commit that referenced this pull request Oct 19, 2024
Fixed
- First features for user settings after vue migration (#2795)
- scroll stops after first bunch of items when they are marked read during scroll (#2814)
- marked read items disappear when showAll is disabled in folder or feed view (#2814)
- Feed item lists are merged when filtered (#2516)
- Mark as read on Scroll (#2503)
- Open news with the last viewed feed or folder (#2507)

Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants