-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue Rewrite] Upmerge Release 22 into Vue Rewrite Branch #2305
[Vue Rewrite] Upmerge Release 22 into Vue Rewrite Branch #2305
Conversation
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
Sounds good to me. |
NC27 only is fine for me too. |
Okay, I will look into removing the hack I added and just running the tests against NC27 |
Signed-off-by: Devlin Junker <[email protected]>
I have attempted to restrict the vue-rewrite to NC27 (can someone review this to make sure I didn't miss anything?) and tested all of the builds here: devlinjunker#128 Once this is reviewed and it builds successfully, can we merge it so we can move forward with these changes to create the Add Feed Component? then I can get to the fun of displaying the feed items! |
Ah the unit tests still need to be adjusted. We also need to change that code on master though. Fine for me like this. |
Related to #748
Follows #2024
Summary
I'm back to help with the migration to Vue!
This upmerge was needed so I could run on the latest NC versions, so I've brought all of the recent changes to this branch and fixed some failing Github Actions and they all pass on this branch now.
NOTE: Please review this one specifically! The fixes here are sort of hacky to get the builds to pass and may not be approved by all...
allowEvalScript
andgetTime
allowEvalScript
because we do not needeval()
for the Vue RewriteTimeFactory->now()->getTimestamp()
instead ofTimeFactory->getTime()
FolderServiceTest.php
to mock the missing methods and allow PHP Unit Tests to pass with NC25, NC26 and NC27 (should we just run the tests against Nextcloud 27 though instead? and the vue rewrite will require NC27+ ?)I tested these changes on my localhost for working on the vue-rewrite and tested that the actions are passing on my local repo: devlinjunker#127
Checklist
Up Next