-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command to check the job status and reset it #2166
Conversation
6b45786
to
2dc33d1
Compare
We might as well make news depend on 26 for this. The old versions will work just as well on lower versions |
True, I will think about that :) |
I'm thinking about merging this after depending on NC26. My current rough plan is to implement a few more improvements related to the updater that will still be available for 24 and 25 (if I manage it before May) After that I would make a cut. Bump the requirement to NC26 and PHP 8.0, 8.1 or 8.2 but I think it will be 8.1. That would include then an update of feedio and this pr + maybe some other things. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2166 +/- ##
============================================
- Coverage 90.77% 0 -90.78%
============================================
Files 65 0 -65
Lines 3176 0 -3176
============================================
- Hits 2883 0 -2883
+ Misses 293 0 -293 ☔ View full report in Codecov by Sentry. |
6f2966d
to
d506bfe
Compare
Signed-off-by: Benjamin Brahmer <[email protected]>
I think this would also be really useful in the server, but let's add it here first. |
Yea I agree, but seems like the background job system so far is not that important to the core business of nextcloud. |
Changed - Drop support for Nextcloud 25, Supported: 26, 27 (#2316) - Add a new command for occ `./occ news:updater:job` allows to check and reset the update job (#2166) - Check for available http(s) compression options and use them (gzip, deflate, brotli) (#2328) - Change and unify [cache](https://nextcloud.github.io/news/install/#cache) to use the instance ID of Nextcloud (#2331) Signed-off-by: Benjamin Brahmer <[email protected]>
Changed - Drop support for Nextcloud 25, Supported: 26, 27 (#2316) - Add a new command for occ `./occ news:updater:job` allows to check and reset the update job (#2166) - Check for available http(s) compression options and use them (gzip, deflate, brotli) (#2328) - Change and unify [cache](https://nextcloud.github.io/news/install/#cache) to use the instance ID of Nextcloud (#2331) Signed-off-by: Benjamin Brahmer <[email protected]>
Summary
This is also a Feature that requires Nextcloud 26
This adds a new command
news:updater:job
that allows to check on the current status of the background job and also allows to reset the job.Resetting may lead to issues if the job is currently running but is certainly better than modifying the DB directly.
I also updated the FAQ a bit and moved the old steps into their own section. I think they can be removed in the future.
This is part of the effort to improve the job situation in news, which is one of the main error sources and reason why people open an issue.
Checklist