Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to check the job status and reset it #2166

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Mar 20, 2023

  • Resolves: n/a

Summary

This is also a Feature that requires Nextcloud 26

This adds a new command news:updater:job that allows to check on the current status of the background job and also allows to reset the job.
Resetting may lead to issues if the job is currently running but is certainly better than modifying the DB directly.

I also updated the FAQ a bit and moved the old steps into their own section. I think they can be removed in the future.

This is part of the effort to improve the job situation in news, which is one of the main error sources and reason why people open an issue.

Checklist

@SMillerDev
Copy link
Contributor

We might as well make news depend on 26 for this. The old versions will work just as well on lower versions

@Grotax
Copy link
Member Author

Grotax commented Mar 20, 2023

True, I will think about that :)

@Grotax Grotax marked this pull request as ready for review March 21, 2023 16:53
@Grotax
Copy link
Member Author

Grotax commented Mar 21, 2023

I'm thinking about merging this after depending on NC26.

My current rough plan is to implement a few more improvements related to the updater that will still be available for 24 and 25 (if I manage it before May)

After that I would make a cut.

Bump the requirement to NC26 and PHP 8.0, 8.1 or 8.2 but I think it will be 8.1.

That would include then an update of feedio and this pr + maybe some other things.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -90.78% ⚠️

Comparison is base (ca9e07b) 90.77% compared to head (1e79a80) 0.00%.

❗ Current head 1e79a80 differs from pull request most recent head ef18f85. Consider uploading reports for the commit ef18f85 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #2166       +/-   ##
============================================
- Coverage     90.77%       0   -90.78%     
============================================
  Files            65       0       -65     
  Lines          3176       0     -3176     
============================================
- Hits           2883       0     -2883     
+ Misses          293       0      -293     

see 65 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SMillerDev
Copy link
Contributor

I think this would also be really useful in the server, but let's add it here first.

@Grotax
Copy link
Member Author

Grotax commented Aug 22, 2023

Yea I agree, but seems like the background job system so far is not that important to the core business of nextcloud.
While news really relies heavily on the job. Since we have no refresh option in the frontend (yet).

@Grotax Grotax merged commit 17f0fc7 into master Aug 22, 2023
25 of 29 checks passed
@delete-merged-branch delete-merged-branch bot deleted the command/job branch August 22, 2023 07:47
Grotax added a commit that referenced this pull request Aug 26, 2023
Changed

- Drop support for Nextcloud 25, Supported: 26, 27 (#2316)
- Add a new command for occ `./occ news:updater:job` allows to check and reset the update job (#2166)
- Check for available http(s) compression options and use them (gzip, deflate, brotli) (#2328)
- Change and unify [cache](https://nextcloud.github.io/news/install/#cache) to use the instance ID of Nextcloud (#2331)

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax mentioned this pull request Aug 26, 2023
Grotax added a commit that referenced this pull request Aug 27, 2023
Changed

- Drop support for Nextcloud 25, Supported: 26, 27 (#2316)
- Add a new command for occ `./occ news:updater:job` allows to check and reset the update job (#2166)
- Check for available http(s) compression options and use them (gzip, deflate, brotli) (#2328)
- Change and unify [cache](https://nextcloud.github.io/news/install/#cache) to use the instance ID of Nextcloud (#2331)

Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants