Chore: split user data from feed data #1706
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
force-pushed
the
chore/mapper/split_user_data
branch
from
78985cc
to
52354a8
Compare
|
Oh that's cool 😎 |
|
I don't think you missed any. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
SMillerDev
force-pushed
the
chore/mapper/split_user_data
branch
from
52354a8
to
6fc4966
Compare
Signed-off-by: Sean Molenaar <[email protected]>
SMillerDev
force-pushed
the
chore/mapper/split_user_data
branch
from
6fc4966
to
2c9e1f6
Compare
| $item_table = $qb->getTableName('news_items'); | ||
| $feed_table = $qb->getTableName('news_feeds'); | ||
|
|
||
| $items_query = "REPLACE INTO $user_item_table SELECT id AS 'item_id', ? AS 'user_id',`unread`,`starred`,`last_modified`,`shared_by` FROM $item_table where feed_id = ?;"; |
There was a problem hiding this comment.
You might have to find a different solution here, since PostgreSQL doesn't have REPLACE INTO statements.
Alternatively, you could check the database type and use another suitable statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of the work to split the user data from the feed data. I'd especially like to know if I missed any user data in the feeds.