Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort order in merged views (folders or "unread") does grouping by feed ressource and does not sort by date only #2626

Open
3 tasks done
rankerson opened this issue Mar 27, 2024 · 4 comments
Labels

Comments

@rankerson
Copy link

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

I want to view my new items in the newsfeed (either in the overview "unread" or clicking on a folder, which includes several feeds. My expectation would be, that all collected feed items (of all feeds in the respective folder or all feeds, if the view "unread" is choosen) are sorted by date (either ASC or DESC depending on the sort order selected in the settings).

I see now, that the feed items are sorted by date in the corresponding sort order, BUT grouped by feed. So I see first all items of one feed sorted by date and then the items of the next feed sorted by date. My expectation is that all feed items are sorted by date w/o grouping by feed. If my expectation does not fit the idea I can also create a pull request.

Steps to Reproduce

Explain what you did to encounter the issue

  1. Create a subfolder with twi different feed sources.
  2. Click on the folder and check the sort order of feed items and if they are grouped by feed ressource

System Information

  • News app version: 24.0.0
  • Nextcloud version: 26.0.7
  • Cron type: (system cron/python updater/...) system cron
  • PHP version: 8.2.11
  • Database and version: mysql, 11.2.2
  • Browser and version: Chrome 123.0.6312.86
  • OS and version: Linux 6.1.0-17-cloud-amd64 x86_64

I skipped the following log-Output as no error message occured and I guess it is just a wrong resp. unexpected behaviour. If additional logs are needed, do not hesitate to ask for it.

@rankerson rankerson added the bug label Mar 27, 2024
@Grotax
Copy link
Member

Grotax commented Mar 27, 2024

Hi, I think this grouping is a side effect of the collection time, each feed is fetched one by one and added to the database.

The items are then sorted by the date they were added. And if I remember right this is done because the date that the feeds use is not very reliable.

But I'm not a 100% sure. The logic is in the data mappers or the service for items

@rankerson
Copy link
Author

Hi, ah, ok. Understand this, but does it makes sense? I understand, that sometimes the date from the feed itself might not be appropiate, but is this not the exeption?

Cheers
Ranki

@Grotax
Copy link
Member

Grotax commented Mar 27, 2024

I guess in the end it would be best to leave this up to the user.

Currently the main topic is that the UI is rewritten with vuejs and that the missing features are added and the bugs are fixed after that we could think again about item sorting

@wofferl
Copy link
Contributor

wofferl commented Oct 5, 2024

The problem here is that the frontend load 40 items at a time and get it sorted by item id from the backend. In merged views sorting by date would mean that items that are loaded later can be sorted above the actual items viewed.
Sorting by date seems difficult, because you either have to load all items for a view or the backend have to be rewritten to give the items sorted by date, which I think would not that easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants