add: j/k shortcuts

add: make first attempt to jump to previous and next feed item

fix: linter errors

fix: use correct feed items

fix: use filterSortedItems()

add: trigger click event programmatically to benefit from item handling
inside FeedItemRow component

add: use a proper item if none is selected

fix: remove not needed MUTATIONS import

add: attempt to scroll to clicked item

doc: add changelog text

Signed-off-by: Patrizio Bekerle <[email protected]>

CHANGELOG.md

@@ -8,6 +8,7 @@ You can also check [on GitHub](https://github.com/nextcloud/news/releases), the
 ## [25.x.x]
 ### Changed
 - added alternative development environment (#2670)
+- Implement `j` and `k` keyboards shortcuts for navigating through feed items (#2671)
 
 ### Fixed
 

package.json

@@ -56,6 +56,7 @@
     "lodash": "^4.17.21",
     "vue": "^2.7.16",
     "vue-router": "^3.5.3",
+    "vue-shortkey": "^3.1.7",
     "vuex": "^3.6.2"
   },
   "browserslist": [

src/components/feed-display/FeedItemDisplayList.vue

@@ -28,14 +28,20 @@
 					</template>
 				</NcActionButton>
 			</NcActions>
+			<button v-shortkey="['k']" class="hidden" @shortkey="jumpToPreviousItem">
+				Prev
+			</button>
+			<button v-shortkey="['j']" class="hidden" @shortkey="jumpToNextItem">
+				Next
+			</button>
 		</div>
 		<div class="feed-item-display-container">
 			<VirtualScroll :reached-end="reachedEnd"
 				:fetch-key="fetchKey"
 				@load-more="fetchMore()">
 				<template v-if="items && items.length > 0">
 					<template v-for="item in filterSortedItems()">
-						<FeedItemRow :key="item.id" :item="item" />
+						<FeedItemRow :key="item.id" :ref="'feedItemRow' + item.id" :item="item" />
 					</template>
 				</template>
 			</VirtualScroll>
@@ -124,6 +130,9 @@ export default Vue.extend({
 		cfg() {
 			return _.defaults({ ...this.config }, DEFAULT_DISPLAY_LIST_CONFIG)
 		},
+		selectedItem() {
+			return this.$store.getters.selected
+		},
 	},
 	mounted() {
 		this.mounted = true
@@ -175,6 +184,55 @@ export default Vue.extend({
 
 			return response.sort(this.sort)
 		},
+		// Trigger the click event programmatically to benefit from the item handling inside the FeedItemRow component
+		clickItem(item: FeedItem) {
+			const refName = 'feedItemRow' + item.id
+			const ref = this.$refs[refName]
+			// Make linter happy
+			const componentInstance = Array.isArray(ref) && ref.length && ref.length > 0 ? ref[0] : undefined
+			const element = componentInstance ? componentInstance.$el : undefined
+
+			if (element) {
+				element.click()
+
+				// TODO: This doesn't seem to do a lot in the VirtualScroll component
+				element.scrollIntoView(true)
+				// this.$nextTick(() => element.scrollIntoView())
+			}
+		},
+		currentIndex(items: FeedItem[]): number {
+			return this.selectedItem ? items.findIndex((item: FeedItem) => item.id === this.selectedItem.id) || 0 : -1
+		},
+		// TODO: Make jumpToPreviousItem() highlight the current item
+		jumpToPreviousItem() {
+			console.log('Previous item')
+			const items = this.filterSortedItems()
+			let currentIndex = this.currentIndex(items)
+			console.log('currentIndex', currentIndex)
+			// Prepare to jump to the first item, if none was selected
+			if (currentIndex === -1) {
+				currentIndex = 1
+			}
+			// Jump to the previous item
+			if (currentIndex > 0) {
+				const previousItem = items[currentIndex - 1]
+				console.log('previousItem', previousItem)
+				this.clickItem(previousItem)
+			}
+		},
+		// TODO: Make jumpToNextItem() highlight the current item
+		jumpToNextItem() {
+			console.log('Next item')
+			const items = this.filterSortedItems()
+			const currentIndex = this.currentIndex(items)
+			console.log('currentIndex', currentIndex)
+			// Jump to the first item, if none was selected, otherwise jump to the next item
+			if (currentIndex === -1 || (currentIndex < items.length - 1)) {
+				const nextItem = items[currentIndex + 1]
+				console.log('nextItem', nextItem)
+				this.clickItem(nextItem)
+			}
+		},
 	},
 })
 </script>

src/main.js

@@ -16,6 +16,7 @@ Vue.prototype.OCA = OCA
 
 Vue.use(Vuex)
 Vue.use(VueRouter)
+Vue.use(require('vue-shortkey'))
 
 Vue.directive('tooltip', Tooltip)